Chlorine pucks are not bad, nor are they good. They are a source of chlorine. What is added along with the chlorine is what causes problems.
Pucks are made with trichlor, which is a form of stabilized solid chlorine that can easily be pressed in to a solid puck. Trichlor is highly acidic, so one downside to using them is the need to be mindful of that and monitor pH and TA especially with regular use. More importantly though is the CYA in trichlor. For every 10 ppm of FC added to a pool via trichlor, 6 ppm CYA is also added. The chlorine is used up but the CYA remains and builds up. Since CYA stabilizes and buffers chlorine, you must use more chlorine to counter the effects as it rises. If using trichlor for regular chlorination then this cycle can quickly get out of hand. That is where pools turn green despite numbers being "good" according to most in the industry.
Trichlor is another tool in the belt, it has its uses in specific circumstances. Regular chlorination is not really one of those circumstances unless you are in a very wet place and constantly draining excess water from the pool. Liquid chlorine adds nothing to the water except chlorine and salt (all forms of chlorine add salt) and is the source of chlorine we recommend the most because of that. When and how to use chlorine pucks is up to the pool owner, as long as the FC is kept within the FC/CYA parameters the water will stay clear no matter how the chlorine is added to the pool.